Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destroy animation players and clean resources #10267

Merged
merged 6 commits into from
Oct 21, 2021
Merged

Destroy animation players and clean resources #10267

merged 6 commits into from
Oct 21, 2021

Conversation

wnvko
Copy link
Contributor

@wnvko wnvko commented Oct 11, 2021 •
edited by Lipata
Loading

Destroy animation players when detach is called. Also clear all the resources attached to OverlayInfo object.
angular/angular#40191

Closes #8450

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@IvayloG IvayloG removed the ❌ status: awaiting-test PRs awaiting manual verification label Oct 13, 2021
@wnvko wnvko added the squash-merge Merge PR with "Squash and Merge" option label Oct 13, 2021
@wnvko wnvko marked this pull request as ready for review October 13, 2021 11:26
@PlamenaMiteva PlamenaMiteva added the 💥 status: in-test PRs currently being tested label Oct 20, 2021
@PlamenaMiteva PlamenaMiteva added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Oct 20, 2021
@wnvko wnvko requested a review from IvayloG October 21, 2021 10:13
@kdinev kdinev merged commit bc37310 into master Oct 21, 2021
@kdinev kdinev deleted the mvenkov/clean-up-overlay-after-detach branch October 21, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvayloG IvayloG IvayloG approved these changes

@jackofdiamond5 jackofdiamond5 Awaiting requested review from jackofdiamond5

Assignees

@PlamenaMiteva PlamenaMiteva

Labels
overlay squash-merge Merge PR with "Squash and Merge" option version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
5 participants
@wnvko @IvayloG @kdinev @PlamenaMiteva @Lipata